Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly detect BuildFinishedEventArgs and return from pipe reading #2

Closed
wants to merge 2 commits into from

Conversation

ltcmelo
Copy link

@ltcmelo ltcmelo commented Jul 1, 2020

Hi @daveaglick , I recently upgraded to 3.0.0 (and 3.0.1) of Buildalyzer but bumped into an issue:

  • the MSBuild pipe logger is hanging for certain apps of my testing pipeline.

Interestingly, all cases where I spotted the problem were upon a BuildFinishedEventArgs. So a temporary "solution" I found was to explicitly detect such event and return upon it.

This does not eliminate the hanging, but at least it allows for me reach the a finally in my Main function and call Environment.Exit(code).

Do you have any idea of what could be going on?

@ltcmelo
Copy link
Author

ltcmelo commented Jul 21, 2021

Hi… I'm wondering whether there is an intend to merge this PR?

I seems that, with .NET 5, more projects are suffering from this hanging issue upon a IProjectAnalyzer.Build(). I added another open source app in the buildalyzer project.

@daveaglick
Copy link
Owner

Yes, I will definitely take a look at this PR soon. It’s summer and I’ve been on vacation so open source time has been limited recently.

@daveaglick
Copy link
Owner

Thanks for taking a look at this @ltcmelo!

Between the changes to the solution file, the modification of the project URL and author (for future reference, changes to package metadata should usually be discussed with package authors before modifying in a PR, especially when changing something like the project URL), and updating the target higher than it needed to be in this PR, I've merged in #6 which just isolates the BuildFinishedEventArgs bit.

Sorry it took so long to get back here - out of sight and out of mind and all that. I'm planning a new MsBuildPipeLogger and Buildalyzer release later today that should resolve your original issue.

@daveaglick daveaglick closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants