-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for Workflow Test Files '*-test.yml' #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
force-pushed
the
add_wf_tests_document_support
branch
from
February 19, 2024 12:25
ecfa614
to
f09c702
Compare
Rename WorkflowLanguageService to LanguageServiceBase and make it generic (for any kind of documents) as it doesn't have anything particularly workflow related about it. Includes more rename refactorings around language services definitions.
Nothing particularly workflow related about it.
versions.ts
For some reason webpack doesn't seem to find the mapping...
Add experimental decorators and emit decorator metadata to tsconfig.json
Unfortunately, the existing yaml-language-server from RedHat has some dependencies that conflict with the browser version of the extension. The code related to schema handling, with some simplifications and adaptations for our use case, has been included here.
To gather workflow inputs and outputs just once per request
To check also for the contents of the inputs
This seems to be valid when creating a wf parameter in the UI but the gxformat2 schema doesn't seem to support it.
davelopez
force-pushed
the
add_wf_tests_document_support
branch
from
May 28, 2024 16:32
3a93886
to
5ded943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
workflow-tests-language-service
package with a basic implementation of a language service for Galaxy workflow tests definition files.It also includes a big refactoring using a new IoC container approach based on
Inversify
and much more test coverage.The schema definition for workflow test files is still experimental (galaxyproject/galaxy#17128) but good enough to be very useful already (thanks to @mvdbeek).
Features:
Given the following associated workflow: