Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated document cache on remote GitHub repositories #73

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

davelopez
Copy link
Owner

When opening a file in GitHub.dev, two virtual documents, with the same contents but different URI schemes, are sent to the language server one with vscode-vfs scheme (editable) and one with github scheme (read-only).

Processing both by the server will result in duplicated diagnostics, so we skip the read-only one.

When opening a file in GitHub.dev two different virtual documents are sent to the language server (`vscode-vfs` and `github`) but the one from `github` is a readonly document.
@davelopez davelopez added the bug Something isn't working label Jun 21, 2024
@davelopez davelopez added this to the v0.5.0 milestone Jun 21, 2024
@davelopez davelopez merged commit 6db3a94 into main Jun 21, 2024
4 checks passed
@davelopez davelopez deleted the fix_document_cache_github branch June 21, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant