Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some completion edge cases in Format2 #78

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Fix some completion edge cases in Format2 #78

merged 4 commits into from
Jun 22, 2024

Conversation

davelopez
Copy link
Owner

  • When the type of an element is Any no completion items should be suggested.
  • If a line's indentation is incorrect, we should not suggest anything. Before this change, the root node in the schema was used by default which was confusing.

@davelopez davelopez added the bug Something isn't working label Jun 22, 2024
@davelopez davelopez added this to the v0.5.0 milestone Jun 22, 2024
@davelopez davelopez merged commit e630dab into main Jun 22, 2024
4 checks passed
@davelopez davelopez deleted the fix_some_completion_edge_cases branch June 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@davelopez