Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to use a different ActiveRecord class than RestClient #7

Open
jpaas opened this issue Dec 20, 2012 · 4 comments
Open

Option to use a different ActiveRecord class than RestClient #7

jpaas opened this issue Dec 20, 2012 · 4 comments

Comments

@jpaas
Copy link

jpaas commented Dec 20, 2012

Thanks for this library, it is a really simple solution to a problem that I seem to encounter a lot. One suggestion I'd like to make is to allow a developer to name their ActiveRecord class something other than "RestClient".
@davesloan
Copy link
Owner

Would you be interested in submitting a patch for this?

@jpaas
Copy link
Author

jpaas commented Mar 14, 2013

I don't mind giving a try. It might not be for a little while because I'm pushing hard on a project for the next month or two.

@larryaasen
Copy link

I really like this Gem and use it in my Konugo server. I am looking into a quick change for this because I ran into a conflict.

larryaasen added a commit to larryaasen/restful_api_authentication that referenced this issue Aug 1, 2013
@larryaasen
## Version 0.2.4
346be9b 
* Closed Issue davesloan#7 - Option to use a different ActiveRecord class than RestClient
* This update involves a lot of changes to a lot of files, but the functionality remains the same. The change was to rename RestClient to RestAppClient and rest_client to rest_client. This avoids a conflict with the popular rest-client gem that uses the same RestClient class name.
@larryaasen larryaasen mentioned this issue Aug 1, 2013
Open
@joshudev
Copy link

This change really should be merged in - I understand the issue of backwards compatibility, but can you not make the class configurable and default it to the original?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@larryaasen @davesloan @jpaas @joshudev