Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support moar properties #509

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

zakybilfagih
Copy link
Collaborator

@zakybilfagih zakybilfagih commented Aug 21, 2024

  • CSS Grid Layout Module Level 3
  • mask-position: bottom 10px right
  • Cleanup properties with <position>

  • Parser.property_perspective
  • Parser.property_grid_template
  • Parser.property_translate
  • Parser.property_rotate
  • Parser.property_scale
  • Parser.property_transition
  • Parser.property_grid_template_columns
  • Parser.property_grid_template_rows
  • Parser.property_grid_template_areas
  • Parser.property_grid_auto_columns
  • Parser.property_grid_auto_rows
  • Parser.property_grid_auto_flow
  • Parser.property_grid
  • Parser.property_grid_row_start
  • Parser.property_grid_column_start
  • Parser.property_grid_row_end
  • Parser.property_grid_column_end
  • Parser.property_grid_row
  • Parser.property_grid_column
  • Parser.property_grid_area

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
styled-ppx ⬜️ Ignored (Inspect) Visit Preview Aug 24, 2024 5:56am

Comment on lines +1075 to +1076
[ `all
| `ident of string
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think is worth keeping the string and allow "all"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this feels unnecessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, i think this is needed since we want to also have Var.t and Cascading.t

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I wonder what's the point of cascading or auto in animation?

@zakybilfagih zakybilfagih marked this pull request as ready for review August 24, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants