Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component does not initialize correctly when currentDate is set and required = false #9

Open
jagthedrummer opened this issue Oct 4, 2016 · 3 comments

Comments

@jagthedrummer
Copy link
Contributor

When required=false AND when a date is passed in to currentDate the component does not initialize the value of the text input correctly. It should initialize to be the formatted value of currentDate, but instead it's left empty, and the placeholder text appears.

Here's a failing test that demonstrates the problem : https://github.com/jagthedrummer/ember-baremetrics-calendar/blob/jeremy/required-test/tests/integration/components/baremetrics-calendar-test.js#L33-L46

I'd be happy to open a PR for this test if that would help.

@jagthedrummer
Copy link
Contributor Author

Looks like this is an upstream issue. When required is set to false they're forcing the initial value to ''. 😞

https://github.com/Baremetrics/calendar/blob/master/dev/js/Calendar.js#L776

@jagthedrummer
Copy link
Contributor Author

I opened an issue on the upstream project.

Baremetrics/calendar#63

@jagthedrummer
Copy link
Contributor Author

The upstream repo has been fixed. Baremetrics/calendar@524c55b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant