From d373b0fef563c777ec0b3f07bee5e4944419b3e7 Mon Sep 17 00:00:00 2001
From: David Alpert <david@spinthemoose.com>
Date: Sat, 8 May 2021 09:18:54 -0500
Subject: [PATCH] GH-49 disable (for now) the mysql tests in ci.yml

no point in running the mysql integration tests until
they are actually testing the evaluators
---
 .github/workflows/ci.yml | 73 ++++++++++++++++++++--------------------
 1 file changed, 37 insertions(+), 36 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 5d7328e..503c59d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -41,39 +41,40 @@ jobs:
       run: go run utils/ci.go build
     - name: Test
       run: go run utils/ci.go test --integration -v
-  mysqltest:
-    strategy:
-      fail-fast: false # dont' want one scenario failing to deprive us of feedback on the others
-      matrix:
-        go-version: [1.14.x, 1.15.x]
-        os: [ubuntu-latest]
-    runs-on: ${{ matrix.os }}
-    services:
-      mysql:
-        image: mysql:5.7
-        env:
-          MYSQL_USER: godbledger
-          MYSQL_PASSWORD: password
-          MYSQL_DATABASE: ledger
-          MYSQL_ROOT_PASSWORD: password
-        ports:
-          - 3306
-        options: --health-cmd="mysqladmin ping" --health-interval=10s
-    steps:
-    - name: Verify MySQL connection
-      env:
-        PORT: ${{ job.services.mysql.ports[3306] }}
-      run: |
-        while ! mysqladmin ping -h"127.0.0.1" -P"$PORT" --silent; do
-          sleep 1
-        done
-    - name: Install Go
-      uses: actions/setup-go@v2
-      with:
-        go-version: ${{ matrix.go-version }}
-    - name: Checkout code
-      uses: actions/checkout@v2
-    - name: Build
-      run: go run utils/ci.go build
-    - name: Test
-      run: go run utils/ci.go test --mysql -v
+# TODO: these mysql test currently bypass the end-to-end test pattern effectively testing only that configuration is loaded
+#  mysqltest:
+#    strategy:
+#      fail-fast: false # dont' want one scenario failing to deprive us of feedback on the others
+#      matrix:
+#        go-version: [1.14.x, 1.15.x]
+#        os: [ubuntu-latest]
+#    runs-on: ${{ matrix.os }}
+#    services:
+#      mysql:
+#        image: mysql:5.7
+#        env:
+#          MYSQL_USER: godbledger
+#          MYSQL_PASSWORD: password
+#          MYSQL_DATABASE: ledger
+#          MYSQL_ROOT_PASSWORD: password
+#        ports:
+#          - 3306
+#        options: --health-cmd="mysqladmin ping" --health-interval=10s
+#    steps:
+#    - name: Verify MySQL connection
+#      env:
+#        PORT: ${{ job.services.mysql.ports[3306] }}
+#      run: |
+#        while ! mysqladmin ping -h"127.0.0.1" -P"$PORT" --silent; do
+#          sleep 1
+#        done
+#    - name: Install Go
+#      uses: actions/setup-go@v2
+#      with:
+#        go-version: ${{ matrix.go-version }}
+#    - name: Checkout code
+#      uses: actions/checkout@v2
+#    - name: Build
+#      run: go run utils/ci.go build
+#    - name: Test
+#      run: go run utils/ci.go test --mysql -v