-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Can't open camera on adding new element #733
Comments
Works here on my pixel 6a running LineageOS/Android 13. Have you changed the default camera app? |
No, my phone is stock with latest Google official firmware and official photo apps Here the video Issue |
Seeing the same on Divest OS 20 (aka Android 13) based on Lineage Trying the older version, which opens the camera fine fyi, it appears that now you don't ask for Storage permissions of any kind (Photos and whatnot)? But testing on Android 11 I get asked for Storage on start and the camera works fine. /PS: you've bumped targetSDK from 31 to 33... maybe it needs more work? |
I'm using Android 13 (Lineage) on my Pixel 6a without issue. So I don't think it's a universal problem. |
There's no obvious crash:
...clean data, start, go straight to camera, grant permission, error. Note that touching the area near the camera/picker it might open the camera eventually, eg. I pressed 2 dozen times just for kicks really fast (see the log entry with "Camera.takePicture blocked" so maybe there's a race?) but the picture was not saved (since you don't ask nor get the permission to store the picture lol) |
So you've installed fresh today and works fine for you? |
I haven't reinstalled it today, I'm using the latest version from fdroid. |
Please do, as said, latest from F-Droid works fine, but that's on tagetSDK 31... But this APK: https://github.com/davidhealey/waistline/releases/tag/3.7.1 and whatever F-Droid will build in the next cycle (https://gitlab.com/fdroid/fdroiddata/-/commit/022728913b80bed68a7a69753c68c070e778b962) won't open the camera nor open the files on Android 13. |
Aha ok I'll try that. @EmilJunker I seem to recall you updated the SDK version? |
I've tried also the latest downloaded from GitHub Did you see my video ? Tell me if you Need other information, logcat |
@Linskun @licaon-kter Are you able to create a database backup from |
@EmilJunker : Export Failed |
@Linskun Thank you for confirming. I thought so. Then it must have something to do with the changed storage access permissions that were introduced in Android 13 (SDK 33). I guess we need to add some permissions to the config.xml besides READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE. |
Or actually we may have to wait for the camera plugin itself to get fixed, see apache/cordova-plugin-camera#825 (comment) |
@EmilJunker What was the reason for updating the SDK? |
The main reason was because I wanted to add support for themed app icons (issue #675) which is a new feature in Android 13 that requires Cordova Android 12 and SDK 33. |
Ah yes, I remember now, thanks |
Isn't Google forcing everyone anyway? |
Unfortunately yes, from August 31, apps submitted to the Play Store are required to target at least SDK 33: https://developer.android.com/google/play/requirements/target-sdk On the plus side, that would give us three more weeks to make and publish a version that targets SDK 32 (which is unaffected by the issue). To make a working version that targets SDK 33, it looks like we'll need to wait for the camera plugin and the file plugin to be fixed: |
Uh why they always breaking stuff!!! :) |
Wait, ain't |
@licaon-kter Yes, some file managers block access to |
You got it backwards, Google blocks their access... but yeah. Are you really really sure Documents is blocked? |
I couldn't find a way to write to the Documents folder on Android 13. Maybe there is a way to do it with a native app, but with Cordova we have to rely on plugins to provide this functionality. You are welcome to try to make it work, though. The app is open source ;) |
Ah, so a matter of time :) |
Hi, I've incorporated Emil's temporary fix, but I since I had to install some new stuff I would appreciate if a few of you could test it before I make an official release. |
@davidhealey I installed your APK on my S21 running Android 13 and can confirm that it's fixed. I can add pictures to food items and the backup is also working as expected. |
Perfect thanks, in that case I'll go ahead and make the release. I'll leave this issue open until the official plugin is fixed. |
I have no experience with coding for Android, but is there a chance the fixes described at https://stackoverflow.com/questions/38832592/cordova-file-plugin-save-file-in-device/38900101#38900101 or https://stackoverflow.com/questions/43575581/cordova-download-a-file-in-download-folder/43576537#43576537 can work here? |
Hello,
i have a Pixel 6a with latest Android 13 update.
I can't add a picture on adding new element/food, the UI say that "There was a problem using the camera"
If i use camera to scan a bar code it work, so It doesn't look like a permissions issue
The text was updated successfully, but these errors were encountered: