Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doOnEmpty implementation #16

Open
davidmoten opened this issue Jun 30, 2016 · 1 comment
Open

doOnEmpty implementation #16

davidmoten opened this issue Jun 30, 2016 · 1 comment

Comments

@davidmoten
Copy link
Owner

davidmoten commented Jun 30, 2016 •
edited
Loading

This operator moved to rxjava-extras master branch from ReactiveX/RxJava#3624.

cc/ @thomasnield (author)

  • converted to OnSubscribeDoOnEmpty to save allocations associated with lift
  • removed done checks because of guarantees of observable contract
  • added unit tests, now at 100% coverage

@thomasnield if I've missed something pls let me know, when it looks good to you I'll release to Maven Central.
@thomasnield
Copy link

I've never seen this interface implemented over an Operator before, much less wrapped into a Transformer and creating a separateObservable off it. I'm curious so I'll check this out for my own learning, but I trust your judgement more than mine! Thanks for including this operator and asking : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidmoten @thomasnield