Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absolute vs relative pressure #140

Open
8 of 12 tasks
davidrg opened this issue Aug 15, 2021 · 0 comments
Open
8 of 12 tasks

Fix absolute vs relative pressure #140

davidrg opened this issue Aug 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@davidrg
Copy link
Owner

davidrg commented Aug 15, 2021 •
edited
Loading

Currently the sample and live data table only has an absolute pressure column. The Davis logger currently logs relative pressure there and the UI generally refers to it as relative pressure. I'm unsure what wh1080d logs.

Davis stations can supply absolute pressure (via LOOP2 packets) and #131 will add support for it. This means that this naming thing really needs to be fixed.

  • Add mean_sea_level_pressure columns to the sample and live data tables
  • Adjust davis logger to log relative pressure to the mean_sea_level_pressure column
  • Adjust weather-push
  • Adjust web UI
  • Adjust server
  • weather-plot
  • Adjust desktop client
  • Adjust WOW updater
  • Adjust anything else currently dealing with pressure data
  • Adjust davis logger to no longer log anything to the absolute pressure column in the DB for samples.
  • Deploy new versions of everything everywhere (fremont, hamilton, sandy-bay)
  • Move data for all davis stations from the existing absolute pressure column to the new relative pressure column (because thats what it is)

This probably needs to wait for the current bugs in weather-push (like #4) to be fixed so it can be deployed to the Hamilton-SandyBay link as all components of the current zxweather deployment will need upgrading together.
@davidrg davidrg added the enhancement New feature or request label Aug 15, 2021
davidrg added a commit that referenced this issue Aug 28, 2021
@davidrg
DavisLogger: Now receives LOOP2 packets (#131). Also adds sea level p…
e114ee5 
…ressure columns (#140)

And makes that data available via new columns in the database as well as RabbitMQ.

This commit also adds database columns for mean sea level pressure. The appropriate values are now logged to the appropriate places for live data.

Davis logger for now logs the same value to both absolute and mean sea level pressure columns for samples rather than leaving the absolute pressure column as null. This will be changed near the end of ticket #140 before the data migration step.
davidrg added a commit that referenced this issue Sep 7, 2021
@davidrg
Plot: Port to python 3 (#6) and add support for MSL pressure (#140)
45c1baf 
Also tidied up a few (but not all) PEP-8 problems
davidrg added a commit that referenced this issue Feb 11, 2022
@davidrg
Desktop: Handle separation of absolute and MSL pressure (#140)
3b7ad31 
It will now use the samples_v2.dat data source where available and store absolute and mean sea level pressure separately in the cache database.

SC_Pressure column is now a coalesce of MSL and ABS pressure. There are separate SC_AbsolutePressure and SC_MeanSeaLevelPressure options at the data layer but these are not currently surfaced in the UI as no currently supported hardware type supplies both.
davidrg added a commit that referenced this issue Feb 11, 2022
@davidrg
WOWUpdate: Should now handle MSL (#140)
1292fc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidrg