Add an optional filterFn to PubSubAsyncIterator to workaround performance issues found in withFilter #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our production application filters a high number of messages, more than 99% are filtered out. We suffered an issue of unbounded memory growth caused by the behavior of
withFilter
. Our understanding is thatwithFilter
will continue chaining promises together until a message is accepted. Because of our aggressive filtering our containers would quickly run out of memoryWe have since improved our sharding behavior so that we are filtering less messages, but we still think there is an improvement that can be made to filtering.
This PR adds a
filterFn
toPubSubAsyncIterator
so that messages can be filtered immediately before insertion into the queue. We believe this is a performance win regardless of how many messages are being filtered. Thank you!