Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media queries should target height as well as width #3

Open
dawaltconley opened this issue Apr 12, 2023 · 0 comments
Open

Media queries should target height as well as width #3

dawaltconley opened this issue Apr 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dawaltconley
Copy link
Owner

It should be possible to set height requirements on background images and picture elements (using the media property of their source elements).

Generating the right media queries and markup is not too much of a problem; I got something like this working on a previous (Jekyll-specific) iteration. The bigger issue is how to specify height-and-width requirements.

I originally wrote the bg-size-parser to help with this, since I mostly find height restrictions useful for background images. Ideally, I'd like to use syntax / examples being proposed for a future sizes/srcset spec.

@dawaltconley dawaltconley added the enhancement New feature or request label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant