Get rid of some dead code in NbClipboard.

The fields lastWindowActivated, lastWindowDeactivated, and lastWindowDeactivatedSource, and the related conditions were no longer in actual use; this can be seen by reading through the code.

It seems the condition that once used lastWindowActivated was at some point replaced by a call to Task.waitFinished. So there wasn't a mistake; just some unused code left around. See the relevant commit from 2012: eirikbakke/netbeans-releases@6de619c#diff-69d67e2e5b062ae995069c62294958e6e24a42c599cc6684c47f89b086c20278

platform/o.n.bootstrap/src/org/netbeans/NbClipboard.java

@@ -60,9 +60,6 @@ public final class NbClipboard extends ExClipboard
     private Lookup.Result<ExClipboard.Convertor> result;
     final boolean slowSystemClipboard;
     private Transferable last;
-    private long lastWindowActivated;
-    private long lastWindowDeactivated;
-    private Reference<Object> lastWindowDeactivatedSource = new WeakReference<>(null);
     private volatile Task setContentsTask = Task.EMPTY;
     private volatile Task getContentsTask = Task.EMPTY;
     private boolean anyWindowIsActivated = true;
@@ -279,14 +276,12 @@ final void waitFinished () {
         getContentsTask.waitFinished ();
     }
 
-    final void activateWindowHack (boolean reschedule) {
+    /** Used by tests only. */
+    final void activateWindowHack () {
         // if WINDOW_DEACTIVATED is followed immediatelly with
         // WINDOW_ACTIVATED then it is JDK bug described in
         // issue 41098.
-        lastWindowActivated = System.currentTimeMillis();
-        if (reschedule) {
-            scheduleGetFromSystemClipboard(true);
-        }
+        scheduleGetFromSystemClipboard(true);
     }
 
     private void logFlavors (Transferable trans, Level level, boolean content) {
@@ -340,8 +335,6 @@ public void eventDispatched(AWTEvent ev) {
             return;
 
         if (ev.getID() == WindowEvent.WINDOW_DEACTIVATED) {
-            lastWindowDeactivated = System.currentTimeMillis();
-            lastWindowDeactivatedSource = new WeakReference<>(ev.getSource());
             anyWindowIsActivated = false;
             if( Utilities.isWindows() ) {
                 //#247585 - even listening to clipboard changes when the window isn't active
@@ -356,10 +349,6 @@ public void eventDispatched(AWTEvent ev) {
                 fireChange();
             }
             anyWindowIsActivated = true;
-            if (System.currentTimeMillis() - lastWindowDeactivated < 100 &&
-                ev.getSource() == lastWindowDeactivatedSource.get()) {
-                activateWindowHack (false);
-            }
             if (log.isLoggable (Level.FINE)) {
                 log.log (Level.FINE, "window activated scheduling update"); // NOI18N
             }

platform/o.n.bootstrap/test/unit/src/org/netbeans/NbClipboardNativeTest.java

@@ -146,7 +146,7 @@ public void testWhenCallingGetContentsItChecksSystemClipboardFirstTimeAfterActiv
 
 
         // just simulate initial switch to NetBeans main window
-        ec.activateWindowHack (true);
+        ec.activateWindowHack ();
         waitFinished (ec);
 
         if (listenerCalls == 0) {
@@ -179,7 +179,7 @@ public void testWhenCallingGetContentsItChecksSystemClipboardFirstTimeAfterActiv
         if (slowClipboardHack ()) {
             assertEquals ("The getContents rechecked the clipboard just for the first time, not now, so the content is the same", "data2", s);
 
-            ec.activateWindowHack (true);
+            ec.activateWindowHack ();
             Thread.sleep (200);
 
             t = this.ec.getContents(this);