Downport optional parameter fix to 4.3 (#316)

see #315
dbosoft · Nov 19, 2024 · 2803d0e · 2803d0e
1 parent 27295b3
commit 2803d0e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/YaNco.Core/Internal/Api.cs b/src/YaNco.Core/Internal/Api.cs
@@ -130,7 +130,7 @@ public static RfcRc AddFunctionParameter(FunctionDescriptionHandle descriptionHa
                 Name = parameterDescription.Name,
                 Type = parameterDescription.Type,
                 Direction = parameterDescription.Direction,
-                Optional = parameterDescription.Optional ? 'X' : '\0',
+                Optional = parameterDescription.Optional ? '1' : '0',
                 Decimals = parameterDescription.Decimals,
                 NucLength = parameterDescription.NucLength,
                 UcLength = parameterDescription.UcLength,
@@ -158,7 +158,7 @@ public static RfcRc GetFunctionParameterDescription(FunctionDescriptionHandle de
         {
             var rc = Interopt.RfcGetParameterDescByName(descriptionHandle.Ptr, name.ToUpperInvariant(), out var parameterDescr, out errorInfo);
             parameterInfo = new RfcParameterInfo(
-                parameterDescr.Name, parameterDescr.Type, parameterDescr.Direction, parameterDescr.NucLength, parameterDescr.UcLength, parameterDescr.Decimals, parameterDescr.DefaultValue, parameterDescr.ParameterText, parameterDescr.Optional == 'X');
+                parameterDescr.Name, parameterDescr.Type, parameterDescr.Direction, parameterDescr.NucLength, parameterDescr.UcLength, parameterDescr.Decimals, parameterDescr.DefaultValue, parameterDescr.ParameterText, parameterDescr.Optional == 1);
             return rc;
 
         }
@@ -168,7 +168,7 @@ public static RfcRc GetFunctionParameterDescription(FunctionDescriptionHandle de
         {
             var rc = Interopt.RfcGetParameterDescByIndex(descriptionHandle.Ptr, (uint)index, out var parameterDescr, out errorInfo);
             parameterInfo = new RfcParameterInfo(
-                parameterDescr.Name, parameterDescr.Type, parameterDescr.Direction, parameterDescr.NucLength, parameterDescr.UcLength, parameterDescr.Decimals, parameterDescr.DefaultValue, parameterDescr.ParameterText, parameterDescr.Optional == 'X');
+                parameterDescr.Name, parameterDescr.Type, parameterDescr.Direction, parameterDescr.NucLength, parameterDescr.UcLength, parameterDescr.Decimals, parameterDescr.DefaultValue, parameterDescr.ParameterText, parameterDescr.Optional == 1);
             return rc;
 
         }