Output all Fields from RFC Response

[iamNoah1]

The examples show how we can output specific Fields from an RFC request. How can I achieve outputting every fields that get returned from a RFC request?

[fw2568]

Hello Noah,

sorry for the late answer, but I was on holiday.

Yes, that' s possible.
If you just would like to get all fields of a known table / structure you can also use the ToDictionary method of the IStructure interface:

return context.CallFunction("BAPI_DOCUMENT_GETDETAIL2",
    Input: f => f
        .SetField("DOCUMENTTYPE", documentId.Type)
        .SetField("DOCUMENTNUMBER", documentId.Number)
        .SetField("DOCUMENTPART", documentId.Part)
        .SetField("DOCUMENTVERSION", documentId.Version)
        .SetField("GETDOCFILES", "X")
    Output: f =>
        from documentData in f.MapStructure("DOCUMENTDATA", s => s.ToDictionary())
        from files in f.MapTable("DOCUMENTFILES", s => s.ToDictionary())
        select new Document
        {
            DocumentData = documentData,
            Files = files
        });

If you would like to dynamically evaluate all fields of the function you can use the IRfcRuntime interface to query fields of function module with GetFunctionParameterCount and GetFunctionParameterDescription (index signature).
The Structure implementation contains a method that queries all fields of a structure - you can use the same logic to get all fields from a function handle:

YaNco/src/YaNco.Core/Structure.cs

Lines 15 to 27 in e7e4303

	public Either<RfcErrorInfo, RfcFieldInfo[]> GetFieldInfos()
	{
	return RfcRuntime.GetTypeDescription(Handle).Use(used => used
	.Bind( handle =>
	{
	return RfcRuntime.GetTypeFieldCount(handle).Bind(fieldCount =>
	{
	return Enumerable.Range(0, fieldCount).Map(i =>
	RfcRuntime.GetTypeFieldDescription(handle, i)).Traverse(l=>l);
	});
	})).Map(r => r.ToArray());
	}

Hope that helps.

[iamNoah1]

Thanks for the response. Looks good, but I have to evaluate explicitly in the next days.

[iamNoah1]

Hi @fw2568, one year later I found the time to try it finally ^^ ... Your example showed to work with known structures. My issue is that I want to have something generic. There are different structures and I just want to build a generic json structure from it whatever it is. Is that possible?

[iamNoah1]

wow, thank you very much for the efforts. Unfortunately, your suggestion throws a NotSupportedException ("Reading a field of RfcType TABLE is not supported for this method.") exception inside the ToDictionary extension method.

public static Either<RfcErrorInfo, IReadOnlyDictionary<string, object>>
            ToDictionary(this Either<RfcErrorInfo, IFunction> func, IEnumerable<RfcParameterInfo> parameters)
    {
        return parameters.Map(parameter =>
        {
            switch (parameter.Type)
            {
                case RfcType.TABLE:
                    return func.MapTable(parameter.Name, s => s.ToDictionary()) // here
                        .Map(r => (parameter.Name, (object)r.ToArray()));
                case RfcType.STRUCTURE:
                    return func.MapStructure(parameter.Name, s =>
                            s.ToDictionary())
                        .Map(d => (parameter.Name, (object)d));
                default:
                    return func.GetField<AbapValue>(parameter.Name).Map(v => (parameter.Name, (object)v));
            }

        }).Traverse(l => l).Map(e => e.ToHashMap().ToDictionary());

    }

ToDictionary from the IStructure Interface calls somewhere under the hood, GetField from the DefaultFieldMapper, which does not support Tables as field. I will try to wrap my head around it and try to understand what is going on to fix the issue. In the meanwhile I am of course happy for any suggestions :)

[fw2568]

Sorry for the delay, I had planned to provide a solution this week, but it will take a little bit more time.
The solution provided should still work for flat functions (so functions without deep structures as result as all BADIs and almost any RFC enabled function).

[fw2568]

added a issue for this: #194

[fw2568]

Issue #194 is fixed with release 4.2.2. Release is currently in deployment and should be available on nuget within the next hours.
I have also added a updated version of the AbapValueJsonConverter to the integration test app SAPSystemTests:

https://github.com/dbosoft/YaNco/blob/093d71590442f1f12617a034932147ba4f001707/test/SAPSystemTests/AbapValueJsonConverter.cs

I will also check if I can add something like GetFunctionOutputParameters to the core library with a later release.

[iamNoah1]

No worries at all, I am very thankful for your overall responsiveness and support :) Apparently talking to an SAP via RFC is nothing that folks do a lot nowadays, huh. So this Framework is kinda my last hope ^^. I will start testing.