Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open things #1

Open
15 of 26 tasks
kurzum opened this issue Nov 8, 2021 · 7 comments
Open
15 of 26 tasks

open things #1

kurzum opened this issue Nov 8, 2021 · 7 comments
Assignees

Comments

@kurzum
Copy link
Member

kurzum commented Nov 8, 2021

TODO

TODO Sebastian:

  • check out and test /DAV/ https://aksw.slack.com/archives/C026TK7LPNF/p1638976278001200
  • test git files with wc -l
  • delete needs prefix as well and tests
  • think about delete/list ops, KY: one problem…. with the prefix now it is possible to create several graphs for one file… so when you delete the second one, the file wont be there and will for now throw 500 i think… what should we actually do? or we should check if the file already exists and not create the second graph?

Some potential features:

  • since we went for graphs now, it might be possible to 1. upload shacl test graphs and then reference them 2. directly from shacl/validate with ?use=/shacl/mytest or 3. even add the check to graph/save -> ?validateWith=/shacl/mytest
  • git needs to be exploited more, read-only, either allow git clone http://localhost:3002/git/myrepo or add a true git web viewer, maybe from here: https://www.slant.co/topics/425/~best-git-web-interfaces , https://gitlist.org/

DONE:

  • file ids -> content negotiation
  • check tests and fix them (1. iteration)
  • rename dev -> master
  • add Proxyservlet and remove nginx
  • switch to ODBC
  • render swagger.yaml at localhost:3002/ or localhost:3002/index.html -> try to make a prototype with 1 method commented properly, (description and example)
  • Virt user always seems to be "dba" and can be removed from config (no way to change it in virtuoso docker)
  • change name to gstore in sbt instead of dataid-repo
  • rename /git/ to /g/ , first check, whether these work as proxy rule: https://github.com/dbpedia/gstore/blob/dev/tests/test_api_functionality.sh#L46 to file/read
  • graph id Graph ID needs to match some other URI #4
  • rename /file/read to graph/read
  • sed 's|/file/|/graph/|' over test_docker and test_api
  • save files as jsonld Save files always in jsonld #6

Backlog:

  • config params for virtuoso and git need to be more explicit git-engine=local/remote
  • although the basedir param was introduced it is not effective: 1. logback.xml contains a static mention, 2. gitLocalPath is still defined separately -> basedir has no effect
  • startup order https://docs.docker.com/compose/startup-order/ -> gstore should wait for virtuoso, but this seems difficult to implement
@kurzum kurzum changed the title some small things open things Nov 9, 2021
@manonthegithub
Copy link
Collaborator

Pushed the latest dev into master

@manonthegithub
Copy link
Collaborator

nginx was removed

@manonthegithub
Copy link
Collaborator

JDBC works

@manonthegithub
Copy link
Collaborator

@kurzum startup order needs to be discussed, this is not a problem of docker, but of store app. We can make gstore reporting that it is ready only when it has successfully connected to virtuoso. should be enough

@manonthegithub
Copy link
Collaborator

@kurzum you dint put logging of requests here (do we need them?). I suppose you forgot

@kurzum
Copy link
Member Author

kurzum commented Nov 24, 2021

@kurzum you dint put logging of requests here (do we need them?). I suppose you forgot
@manonthegithub Please feel free to add things which we discussed in telcos or slack to the list

@kurzum startup order needs to be discussed, this is not a problem of docker, but of store app. We can make gstore reporting that it is ready only when it has successfully connected to virtuoso. should be enough

This should be solved by the bash script manual testing for now, which is run after docker-compose up . So it can go to backlog

@holycrab13
Copy link
Contributor

Interface for consideration:
https://gitlist.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants