Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unstable SessionStatus from proto and just keep it in SDK or Storage Node #233

Closed
jingchen2222 opened this issue Dec 12, 2022 · 1 comment · Fixed by #291
Closed
Assignees

Comments

@jingchen2222
Copy link
Collaborator

Motivations

We use proto QuerySessionInfo to maintain the query session information. However, status is changeable. So, it is not suitable to be kept inside the proto.
In this issue, we are going to remove status from QuerySessionInfo and will put status in SessionManager instead.

message QuerySessionInfo {
    // the hex encoded string
    int32 id = 1;
    int64 start_time = 2;
    SessionStatus status = 3;
    int32 query_count = 4;

}

Remove the unstable status field and just keep it in SDK or Storage Node

  • Would you like to implement this feature? [y/n]

Solution

Alternatives

Additional context

@jingchen2222
Copy link
Collaborator Author

jingchen2222 commented Jan 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant