Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Apache Iceberg on Snowflake #172

Open
aPeterHeise opened this issue Oct 31, 2022 · 11 comments
Open

Add Support for Apache Iceberg on Snowflake #172

aPeterHeise opened this issue Oct 31, 2022 · 11 comments
Labels

Comments

@aPeterHeise
Copy link
Contributor

Snowflake added support for Apache Iceberg.

There seem to be two ways on how this will be implemented:

  • external table with table_format specification (similar to Snowflake delta support #138), this will be an easy fix
  • fully supported iceberg tables with full DML support, expected syntax: "create or replace iceberg table my_iceberg_table"

While this feature is still in private preview, I'd like to add it to the backlog here already.

@aPeterHeise aPeterHeise added enhancement New feature or request triage labels Oct 31, 2022
@aPeterHeise
Copy link
Contributor Author

Note, the way that #138 is implemented, option 1 via "external tables" should already work.

    - name: iceberg_tbl
         description: "External table using Iceberg files"
         external:
           location: "@stage"                      # reference an existing external stage
           file_format: "( type = parquet )"       # fully specified here, or reference an existing file format
           table_format: iceberg                   # specify the table format
           auto_refresh: false                     # requires configuring an event notification from Amazon S3 or Azure

@github-actions
Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 23, 2024
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@ShahNewazKhan
Copy link

ShahNewazKhan commented Apr 29, 2024

table_format: iceberg

table_format: iceberg is not supported for create or replace external table anymore.

@dataders
Copy link
Collaborator

@ShahNewazKhan are you suggesting that TABLE_FORMAT = ICEBERG is not possible in Snowflake's CREATE EXTERNAL TABLE command? therefore not possible to add support for it in dbt-external-tables?

@dataders dataders reopened this Apr 29, 2024
@ShahNewazKhan
Copy link

@dataders correct, if you try to use CREATE EXTERNAL TABLE with TABLE_FORMAT = ICEBERG you get the following error:

image

You need to use CREATE OR REPLACE ICEBERG TABLE and specify an external_volume(similar to a snowflake named stage).

@github-actions github-actions bot removed the Stale label Apr 30, 2024
@afranzi
Copy link

afranzi commented Jul 4, 2024

For creating the external iceberg table we would need something like:

CREATE OR REPLACE ICEBERG TABLE {database}.{schema}.{table}
  EXTERNAL_VOLUME='{external_volume}'
  CATALOG='{glue_catalog_integration}'
  CATALOG_TABLE_NAME='{glue_table}'
  CATALOG_NAMESPACE='{glue_database}';

The existing code doesn't support it.

Copy link

github-actions bot commented Jan 1, 2025

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 1, 2025
Copy link

github-actions bot commented Jan 9, 2025

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
@dataders dataders reopened this Jan 9, 2025
@dataders
Copy link
Collaborator

dataders commented Jan 9, 2025

I'd really love to make this happen. If someone would be willing to pair with me it'd make the work much more pleasant and go faster!

@github-actions github-actions bot removed the Stale label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants