Skip to content

Commit

Permalink
Remove premature filtering by date (#17)
Browse files Browse the repository at this point in the history
  • Loading branch information
joellabes authored Feb 28, 2022
1 parent e40b0a6 commit ed7a5cd
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions macros/get_metric_sql.sql
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ with source_query as (

from {{ model }}
where 1=1
{% if start_date %}
and date_day >= '{{ start_date }}'
{% endif %}
{% if end_date %}
and date_day <= '{{ end_date }}'
{% endif %}
{%- for filter in metric.filters %}
and {{ filter.field }} {{ filter.operator }} {{ filter.value }}
{%- endfor %}
Expand Down

0 comments on commit ed7a5cd

Please sign in to comment.