Skip to content

Commit

Permalink
Merge pull request #26 from racibaz/FixIssue25
Browse files Browse the repository at this point in the history
The unused  $targetConnection is made dynamic.
  • Loading branch information
dcblogdev authored Aug 10, 2024
2 parents 905fc60 + 7e0edb1 commit a8b5138
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions src/Console/DbSyncCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,15 @@ public function handle(): bool
$mysqldumpSkipTzUtc = config('dbsync.mysqldumpSkipTzUtc') ? '--skip-tz-utc' : '';

$targetConnection = config('dbsync.targetConnection');
$defaultConnection = config('database.default');

$localUsername = config('database.connections.mysql.username');
$localPassword = config('database.connections.mysql.password');
$localHostname = config('database.connections.mysql.host');
$localPort = config('database.connections.mysql.port');
$localDatabase = config('database.connections.mysql.database');
$defaultConnection = empty($targetConnection) ? $defaultConnection: $targetConnection;

$localUsername = config("database.connections.{$defaultConnection}.username");
$localPassword = config("database.connections.{$defaultConnection}.password");
$localHostname = config("database.connections.{$defaultConnection}.host");
$localPort = config("database.connections.{$defaultConnection}.port");
$localDatabase = config("database.connections.{$defaultConnection}.database");
$localMysqlPath = config('dbsync.localMysqlPath');

if (empty($host) || empty($username) || empty($database)) {
Expand Down

0 comments on commit a8b5138

Please sign in to comment.