Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-app configuration (.platform.app.yaml isn't always in the root (and applications.yaml is a thing too)) #92

Open
matthiaz opened this issue Jan 23, 2023 · 10 comments

Comments

@matthiaz
Copy link

My test project does not have a .platform.app.yaml in the root folder, but in one of the subfolders

So when I try to get the plugin, it gives me an error

ddev get drud/ddev-platformsh
Downloading https://api.github.com/repos/drud/ddev-platformsh/tarball/v0.6.4 
v0.6.4_2589139534.tar.gz 99.83 KiB / ? [----------------------------------------------------------------------------------=---------------------------------------------------------------------------------------------------------------------] 1022.26% 0s 
unable to import yaml file /home/matthiasvanwoensel/PlatformSh/forest/.platform.app.yaml: unable to read file /home/matthiasvanwoensel/PlatformSh/forest/.platform.app.yaml (open /home/matthiasvanwoensel/PlatformSh/forest/.platform.app.yaml: no such file or directory) 

I believe this .platform.app.yaml is hardcoded here: https://github.com/drud/ddev-platformsh/blob/ae0bd9675aa20a7166411a7c1b0805a17a38ab8a/install.yaml#L312

Am I supposed to set the docroot to the folder where .platform.app.yaml lives? (I tried but it's not changing the error)

How would this handle the .platform/applications.yaml?

@rfay
Copy link
Member

rfay commented Jan 23, 2023

I didn't know that .platform.app.yaml could be elsewhere than in the root. I'm not sure we'll plan to deal with that case. Could you please link to docs explaining how it can be elsewhere than in the root?

@gilzow
Copy link
Collaborator

gilzow commented Jan 23, 2023

@matthiaz
Copy link
Author

matthiaz commented Jan 23, 2023 via email

@rfay
Copy link
Member

rfay commented Jan 23, 2023

Thanks both - I guess the thing is we're explicitly not supporting multi-app setups in this add-on at this time.

@rfay rfay changed the title .platform.app.yaml isn't always in the root (and applications.yaml is a thing too) .platform.app.yaml isn't always in the root (and applications.yaml is a thing too) (multi-app not supported) Jan 23, 2023
@gilzow
Copy link
Collaborator

gilzow commented Jan 23, 2023

the applications.yaml can be used in a single application. As an example, we have it set up this way for the Django4 template.

I also believe .platform.app.yaml can be in a subfolder, even for a single application. Having said that, I don't believe it's that common.

@rfay maybe we need to call out in the readme that the add-on does not support multiapps

@rfay
Copy link
Member

rfay commented Jan 23, 2023

Oh, I thought the README already had that, thanks.

@matthiaz
Copy link
Author

matthiaz commented Jan 24, 2023 via email

@lolautruche
Copy link
Contributor

Don't worry @matthiaz it's in the roadmap 😉

@apotek
Copy link

apotek commented Feb 6, 2024

Don't worry @matthiaz it's in the roadmap 😉

Definitely something me and my org would be interested in. This is a common scenario for us.

@GeryDeMerciYanis
Copy link

Looking forward for this feature too 👍

@rfay rfay changed the title .platform.app.yaml isn't always in the root (and applications.yaml is a thing too) (multi-app not supported) Support multi-app configuration (.platform.app.yaml isn't always in the root (and applications.yaml is a thing too)) Apr 3, 2024
@rfay rfay added this to Next TODOs Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: No status
Development

No branches or pull requests

6 participants