Skip to content

Commit

Permalink
fix: make the add-on work with DDEV v1.23.0 (#28)
Browse files Browse the repository at this point in the history
* Service should mount ddev-global-cache

* Update README.md

* Fix error from docker-compose in DDEV v1.23.0
  • Loading branch information
stasadev authored Apr 22, 2024
1 parent 820e15e commit 04f1e0a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@

This repository provides [Redis 7](https://redis.com) container for [DDEV](https://ddev.readthedocs.io/).

It is based on [redis:7-alpine](https://hub.docker.com/_/redis/tags?page=1&name=7) docker image and [DDEV custom compose files](https://ddev.readthedocs.io/en/stable/users/extend/custom-compose-files/)
It is based on [redis:7.2-alpine](https://hub.docker.com/_/redis/tags?page=1&name=7) docker image and [DDEV custom compose files](https://ddev.readthedocs.io/en/stable/users/extend/custom-compose-files/)

## Comparison to **v6** (`ddev/ddev-redis`)
## Comparison to **v6** ([`ddev/ddev-redis`](https://github.com/ddev/ddev-redis))

There are a lot of differences between [v6](https://github.com/ddev/ddev-redis) addon and this one
There are a lot of differences between v6 addon and this one

| Feature | ddev/ddev-redis | ddev/ddev-redis-7 |
| ----------------- | ---------------- | ----------------- |
| Maximum Memory | Unlimited | 512Mb |
| Persistence | No | **Yes** |
| Redis Version | 6.2.5 | 7.2.1 |
| Persistence | Optional | **Yes** |
| Redis Version | 6.x.y | 7.2.x |
| Image Size | ~40Mb | ~11Mb |
| Anonymous Volumes | On every restart | **NO** |
| Anonymous Volumes | No | No |
| Optimized config | No | **Yes** |

### Anonymous volumes - Wait, what?
Expand Down
5 changes: 3 additions & 2 deletions docker-compose.redis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ services:
command: /etc/redis/conf/redis.conf
volumes:
- ".:/mnt/ddev_config"
- "ddev-global-cache:/mnt/ddev-global-cache"
- "./redis:/etc/redis/conf"
- "redis:/data"
expose:
Expand All @@ -22,10 +23,10 @@ services:
deploy:
resources:
limits:
cpus: "2"
cpus: "2.5"
memory: "768M"
reservations:
cpus: "1"
cpus: "1.5"
memory: "512M"
restart: "no"
labels:
Expand Down

0 comments on commit 04f1e0a

Please sign in to comment.