fix: add support for multiple hostnames #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
external_links
don't work properly when you haveadditional_hostnames
oradditional_fqdns
.ddev-selenium-standalone-chrome/docker-compose.selenium-chrome.yaml
Lines 20 to 21 in d11aaf3
It works only for the main URL, but not for additional URLs.
How This PR Solves The Issue
Uses go templates to create the correct
external_links
in.ddev/docker-compose.selenium-chrome_extras.yaml
Manual Testing Instructions
This allows for example to have Mailpit to work automatically without any port change.
Related Issue Link(s)