Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off instrumentation #24

Closed
tyler36 opened this issue Nov 8, 2023 · 4 comments
Closed

Turn off instrumentation #24

tyler36 opened this issue Nov 8, 2023 · 4 comments

Comments

@tyler36
Copy link

tyler36 commented Nov 8, 2023

In the "2023-10-31 Amplitude Analytics" training session, @rfay pointed out (around 29:41) that ddev drush was being used alot and someone may have analytics turned on during testing.

We should confirm that by using this action, we are not unnessasarily contributing to analytics.

@tyler36
Copy link
Author

tyler36 commented Nov 8, 2023

I see we have the following set in action.yaml. Is that enough to prevent analytics for both the 'stable' and 'HEAD' versions of DDEV installed?

    - name: Run test
      env:
        ...
        # Don't send telemetry to amplitude
        DDEV_NO_INSTRUMENTATION: "true"

@rfay
Copy link
Member

rfay commented Nov 8, 2023

Thanks for remembering this. This was fixed as a result of that discovery in

@tyler36
Copy link
Author

tyler36 commented Nov 8, 2023

Thought it was worth a confirmation check.

@rfay
Copy link
Member

rfay commented Nov 8, 2023

Thanks for watching the training and thanks for pointing this out! And still sorry we don't know how to do it where everybody can do it live.

@rfay rfay closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants