Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation weights? #8

Closed
hlhowardliu opened this issue May 11, 2022 · 2 comments
Closed

Observation weights? #8

hlhowardliu opened this issue May 11, 2022 · 2 comments

Comments

@hlhowardliu
Copy link

Hi,

Would it be possible to add support for observation weights? I'm currently duplicating my data as a crude workaround, but having an observation weight option would be really helpful.

Thanks!

@ddsjoberg
Copy link
Owner

Hi @hlhowardliu, Apologies for the delayed response. My sense is that accepting weighted data objects (like those from the survey or srvyr packages) is out of the scope of what I'd like to support.

I would need to think much deeper about the consequences of complex weighting designs and DCA....to my knowledge, there are no manuscripts detailing DCA+complex weighting schemes....

@ddsjoberg ddsjoberg closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2022
@ck37
Copy link
Contributor

ck37 commented Feb 24, 2024

I could also use support for observation weights. Looking at Vickers et al. 2016 Equation 1 (page 3), it seems like we would replace true positives with the sum of weights of those observations, then instead of N divide by the sum of weights for all observations. And the same thing for false negatives. With weights = 1, it would be the same as the current formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants