Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API filter to retrieve only not completed matches #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grichet
Copy link

@grichet grichet commented Jun 2, 2017

Since Toornament API retrieve only the 100 first matches if you don't add a pagination filter, it sometimes retrieve only completed matches. (e.g 120 matches on 140 are completed, retrieve only completed matches and eBot don't display any match).

To prevent that, you should had the 'has_result' filter to '0', to retrieve only pending matches.

In a perfect world you should handle a pagination (in case more than a hundred matches were not completed/pending).

have a nice day ;)

@Iwhite67
Copy link

Iwhite67 commented May 3, 2018

+1 for this @deStrO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants