Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Markdown & Reimplement Syntax Highlighting #19

Merged
merged 10 commits into from
Nov 18, 2023

Conversation

gamemann
Copy link
Member

This PR attempts to mitigate the errors from issue #18. While this doesn't fix the error itself, it does allow us to replace small pieces of content in the article to prevent the error.

The error itself only occurs with react-syntax-highlighter when parsing code blocks. It seems to only happen when there are characters such as @ along with numbers and decimals. For example, this error occurs with the following code block:

```bash
ssh [email protected]
```

This PR forces react-syntax-highlighter to activate only when a language is set. So to fix the above, we remove the Bash language from the syntax highlighting from below.

```
ssh [email protected]
```

Unfortunately, I haven't had any success with fixing the error itself and both libraries are on the latest versions. I've tried reimplementing the syntax highlighter code multiple times to see if it resolves the issue, but sadly no luck.

@gamemann gamemann merged commit feef92b into master Nov 18, 2023
@gamemann gamemann deleted the 20231117-markdownerror branch November 18, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant