Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement adr 245 components (send avatar/player components to scene) #85

Merged
merged 12 commits into from
Nov 15, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Nov 10, 2023

@leanmendoza leanmendoza marked this pull request as draft November 10, 2023 20:36
@leanmendoza leanmendoza requested a review from kuruk-mm November 14, 2023 20:12
@leanmendoza leanmendoza marked this pull request as ready for review November 14, 2023 20:12
@codecov-commenter
Copy link

Codecov Report

Attention: 533 lines in your changes are missing coverage. Please review.

Comparison is base (89bafdc) 14.51% compared to head (632c672) 13.98%.

Files Patch % Lines
...decentraland-godot-lib/src/avatars/avatar_scene.rs 0.38% 260 Missing ⚠️
...ntraland-godot-lib/src/godot_classes/dcl_avatar.rs 2.52% 116 Missing ⚠️
rust/decentraland-godot-lib/src/comms/profile.rs 0.00% 43 Missing ⚠️
...dot-lib/src/scene_runner/components/avatar_data.rs 0.00% 23 Missing ⚠️
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.00% 22 Missing ⚠️
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% 20 Missing ⚠️
...t/decentraland-godot-lib/src/scene_runner/scene.rs 13.33% 13 Missing ⚠️
rust/decentraland-godot-lib/src/comms/ws_room.rs 0.00% 4 Missing ⚠️
rust/decentraland-godot-lib/src/common/rpc.rs 0.00% 3 Missing ⚠️
...rc/scene_runner/components/avatar_modifier_area.rs 0.00% 3 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   14.51%   13.98%   -0.53%     
==========================================
  Files         100      102       +2     
  Lines       11750    12227     +477     
==========================================
+ Hits         1705     1710       +5     
- Misses      10045    10517     +472     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple changes

clean dead code
rename Promise.gd to promise.gd
@leanmendoza leanmendoza requested a review from kuruk-mm November 15, 2023 13:27
@leanmendoza leanmendoza merged commit 5e008a1 into main Nov 15, 2023
3 checks passed
@leanmendoza leanmendoza deleted the feat/implement-adr-245-components branch November 15, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants