Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ~system/Players and some sendBatch events #98

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Nov 17, 2023

  • change AvatarEmoteCommand as growonlyset
  • move Rpc module as scene_api to DCL (remove common)
  • entity_id as reference when it's forward it with references
  • MISSING fix: add delete_entity crdt message
  • change tuple to descriptive struct for dirty crdt state
  • add local api calls vec to op_state

next PR:

  • append emote commands
  • add version property in PlayerIdentityData and solve some TODOs

- change AvatarEmoteCommand as growonlyset
- move Rpc module as scene_api to DCL (remove common)
- entity_id as reference when it's forward it with references
- MISSING fix: add delete_entity crdt message
- change tuple to descriptive struct for dirty crdt state
- add local api calls vec to op_state
@leanmendoza leanmendoza marked this pull request as ready for review November 17, 2023 11:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 702 lines in your changes are missing coverage. Please review.

Comparison is base (0b96b73) 13.84% compared to head (9c567b2) 13.12%.

Files Patch % Lines
rust/decentraland-godot-lib/src/dcl/js/events.rs 0.00% 378 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/js/players.rs 0.00% 133 Missing ⚠️
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% 62 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/js/engine.rs 0.00% 35 Missing ⚠️
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.00% 18 Missing ⚠️
...d-godot-lib/src/dcl/components/proto_components.rs 0.00% 17 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/js/mod.rs 0.00% 17 Missing ⚠️
rust/decentraland-godot-lib/src/dcl/crdt/mod.rs 5.88% 16 Missing ⚠️
...ust/decentraland-godot-lib/src/dcl/crdt/message.rs 0.00% 8 Missing ⚠️
...traland-godot-lib/src/dcl/js/restricted_actions.rs 0.00% 6 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   13.84%   13.12%   -0.73%     
==========================================
  Files         104      106       +2     
  Lines       12365    13053     +688     
==========================================
+ Hits         1712     1713       +1     
- Misses      10653    11340     +687     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza requested a review from kuruk-mm November 17, 2023 11:55
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks greatt! Just few reviews

Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@leanmendoza leanmendoza force-pushed the feat/add-events-and-players-api branch from 9c567b2 to a3465ac Compare November 20, 2023 16:32
@leanmendoza leanmendoza merged commit 9a9512b into main Nov 20, 2023
@leanmendoza leanmendoza deleted the feat/add-events-and-players-api branch November 20, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants