-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: first attempt to virtualize the catalog #1733
Draft
juanmahidalgo
wants to merge
56
commits into
master
Choose a base branch
from
feat/virtualization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: created owners table with corresponding styles * feat: added connection with nft server * feat: added sort by * feat: some fixes * feat: removed unused container * fix: pr comments * fix: imports * fix: pr commentsg * fix: removed change con dev.json * fix: pr comments * fix: changed component name * fix: remove loader * fix: pr comments
* feat: created owners table with corresponding styles * feat: added connection with nft server * feat: added sort by * feat: some fixes * feat: removed unused container * fix: pr comments * fix: imports * fix: pr commentsg * fix: removed change con dev.json * fix: pr comments * fix: changed component name * feat: create listings table component * feat: listings table with mocked data * fix: dates and sytles * feat: connected with api * feat: added empty state to tables - missing listings empty state * feat: added empty state text * fix: added name as possible filter to support marketplace subraph * fix: test * feat: updated dcl shcemas * fix: pr comments * fix: fixed table margin
* feat: created owners table with corresponding styles * feat: added connection with nft server * feat: added sort by * feat: some fixes * feat: removed unused container * fix: pr comments * fix: imports * fix: pr commentsg * fix: removed change con dev.json * fix: pr comments * fix: changed component name * feat: create listings table component * feat: listings table with mocked data * fix: dates and sytles * feat: connected with api * feat: added empty state to tables - missing listings empty state * feat: added empty state text * fix: added name as possible filter to support marketplace subraph * fix: test * feat: updated dcl shcemas * feat: created mint or buy component * fix: pr comments
* feat: created owners table with corresponding styles * feat: added connection with nft server * feat: added sort by * feat: some fixes * feat: removed unused container * fix: pr comments * fix: imports * fix: pr commentsg * fix: removed change con dev.json * fix: pr comments * fix: changed component name * feat: create listings table component * feat: listings table with mocked data * fix: dates and sytles * feat: connected with api * feat: added empty state to tables - missing listings empty state * feat: added empty state text * fix: added name as possible filter to support marketplace subraph * fix: test * feat: updated dcl shcemas * feat: created mint or buy component * fix: pr comments * feat: item detail page * fix: some styles * Feat/latest sales table (#1488) * feat: redesign lastest sales table * fix: table title * fix: removed unused file * fix: pr comments * fix: typo
…table (#1499) * feat: tests for listings and owners table * feat: added best buy option tests * fix: pr comments * fix: test not passing
* feat: new designs item detail page * feat: some styles fixes and issuedId fic * feat: removed localhost on dev env * fix: tests * fix: values in mana and usd * fix: issuedId always rendering
* feat: tables skeleton * feat: save table design * feat: table in listingstable and ownerstable * feat: trasnaction history table * feat: rentalHistory table * feat: last tables remaining * feat: fix imports * fix: tests * feat: fixed actions on collections table * fix: test on best buying opion * fix: pr comments * feat: remove nft server local url
* feat: save changes of cards redesign * feat: wip * feat: fix types * feat: catalog items finished - missing cleaning comments * fix: saga tests * feat: updated common schemas * feat: some fixes * feat: fix on card height and build with best buying option * feat: updated dcl schemas * feat: added plural to listing price * feat: fix comments * feat: added million parse on prices * feat: added million parse on prices * fix: api call to catalog or nft/items * fix: some fixes in cards * fix: tests * fix: remove unnecesary changes * fix: selectors import * feat: last fixes * feat: some fixes * feat: fixed comments * Feat/catalog status filter (#1587) * feat: add new status filter for the catalog * feat: add tests for the getStatus selector and missing files for StatusFilter * feat: add Status filter to the defaultCollapsed object * fix: most_expensive new filter * feat: remove extra enum in object * test: add tests to new sortby options selector * test: update tests * fix: AssetCards styles for Catalog (#1632) --------- Co-authored-by: Juanma Hidalgo <[email protected]>
…1656) * fix: bugs related to status filter and assetType being set wrongly * chore: remove unused variable
* feat: added empty state (#1664) * feat: added empty state * feat: fixed filter search * fix: tests * fix: test * feat: merge with base branch * fix: some styles on itemDetailPage * fix: tests * fix: make mana icon wrap if does not fit in card * fix: removed test typo * fix: comment * fix: comment * fix: listings table total * feat: Add new catalog cards to My List, Accounts and HomePage * chore: add new variable to avoid repeating code * Apply suggestions from code review Co-authored-by: Lautaro Petaccio <[email protected]> Signed-off-by: Juanma Hidalgo <[email protected]> * test: update test beforeEAch --------- Signed-off-by: Juanma Hidalgo <[email protected]> Co-authored-by: Florencia Barreto <[email protected]> Co-authored-by: Lautaro Petaccio <[email protected]>
* feat: catalog styles for the new cards in mobile * fix: adjust card styles
…1678) * feat: added popup if there is an item available for mint on nft page * fix: some fixes * fix: import * fix: removed unused fetch item call
* feat: added other listings table * fix: removed actual nft from table * fix: removed actual nft from table * fix: comments * fix: import * fix: removed unused import
* fix: removed actual nft from table * feat: added bids table * feat: bids * fix: tests * fix: imported react on utils file * fix: warning
* feat: add new logic for the catalog card labels * feat: updates cheapest listing scenario * feat: update the card label logic * fix: wearable preview for test * feat: update logic for cheapest and also mint available * fix: add transform just for mobile * fix: update card logic for newest sort and mint not in range * fix: only show listing range when applied * feat: add new logic for minPrice * chore: comment out unused fn * feat: use isMintInRange util method for logic * feat: add new cards visual effect * fix: style for the mint icon * fix: mobile styles * fix: several bugs with navigation and default filter values * test: update tests logic * test: add test for each card text combination * chore: add translations * feat: add closeIcon to search bar if it has text and rarity filter tooltip * feat: add styles for clear button in search bar * feat: persist emote play mode when changing categories * fix: ENS onlyOnSale not working as expected * chore: rollback mainnet data overrides
* feat: add mobile styles for the new item detail page * chore: remove unused import
* feat: order nft page * fix: removed tsconfig changes
* feat: mobile styles for new NFT detail page * fix: use proper mobile breakpoint
* fix: removed emote tags * change minting icon
* fix: card animatin * fix: added transition to image container
* fix: NFT Detail not showing Mint Popup * fix: use `to` instead of onNavigate
juanmahidalgo
force-pushed
the
feat/unified-markets-v1
branch
2 times, most recently
from
June 1, 2023 15:34
d2b218e
to
66e4738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.