-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Single Sign On #1963
Merged
Merged
feat: Single Sign On #1963
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9976c50
feat: Add sso client
fzavalia e511cd4
fix: Support client
fzavalia f0d4540
fix: Create client stub for tests
fzavalia 9697bbd
feat: Stop storing identity in localstorage
fzavalia fbf2b47
feat: Integrate sso
fzavalia 9696327
fix: Tests
fzavalia 1d375d3
fix: Add tests for disconnect
fzavalia 63e67c4
feat: Update sso client
fzavalia 2cb55d3
feat: Get sso url from env
fzavalia e471e4e
fix: Update message
fzavalia 3b3c9b3
fix: Remove stub lib
fzavalia 9970d12
fix: Tests
fzavalia c6bb6b9
fix: Update package
fzavalia daf693f
fix: Add comments
fzavalia 48f5bec
fix: Add comment
fzavalia e87da88
fix: Add comment
fzavalia cf05219
fix: Update imports
fzavalia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
"dependencies": { | ||
"@dcl/crypto": "^3.0.0", | ||
"@dcl/schemas": "^8.1.0", | ||
"@dcl/single-sign-on-client": "^0.0.11", | ||
"@dcl/ui-env": "^1.2.0", | ||
"@ethersproject/providers": "^5.6.2", | ||
"@well-known-components/fetch-component": "^2.0.1", | ||
|
@@ -113,5 +114,10 @@ | |
"last 1 safari version" | ||
] | ||
}, | ||
"homepage": "" | ||
"homepage": "", | ||
"jest": { | ||
"moduleNameMapper": { | ||
"@dcl/single-sign-on-client": "identity-obj-proxy" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As the module is an ESM and not CommonJs, jest doesn't like it. Doing this will replace it in tests with a mockable stub. |
||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package has some unsupported operators by the bundler version used here like
??
. So it has to be added in the overrides.