Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public key format #219

Closed
BasileiosKal opened this issue Oct 6, 2022 · 3 comments
Closed

Public key format #219

BasileiosKal opened this issue Oct 6, 2022 · 3 comments
Labels
core Associated to the core spec

Comments

@BasileiosKal
Copy link
Contributor

When using the public key as input to Sign, Verify etc., we can define it either as a point of G2 or as an octet string. Rn we do the later, consistent with what the BLS spec does.

That said, passing it as a G2 point, will simplify the encode for has operation a bit, since we don't need a "special clause" there so we would not append it with it length, since it would be handled like any other point. See also here for context.

IMO defining it as an octet string is more intuitive, but Im fine with both.

@tmarkovski
Copy link
Member

Would it make sense to do the same for the secret key (instead "non negative integer mod r") and treat is as scalar, the same way the messages are?

@tplooker tplooker added the core Associated to the core spec label Oct 17, 2022
@tplooker
Copy link
Member

tplooker commented Dec 5, 2022

I'm in favour of keeping this as octet string based input.

@BasileiosKal
Copy link
Contributor Author

Discussed on WG call on 20th of Mar. Related to #246 and #223. Closing in favor of those issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Associated to the core spec
Projects
None yet
Development

No branches or pull requests

3 participants