Update encoding rules #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft-looker-cfrg-bbs-signatures.md
Outdated
| 7. el_octs = I2OSP(length(el), 8) || el | ||
| 8. else if el is a Point in G1: el_octs = point_to_octets_g1(el) | ||
| 9. else if el is a Point in G2: el_octs = point_to_octets_g2(el) | ||
| 4. if el is an octet string representing a public key: |
There was a problem hiding this comment.
Is this used? Why not just pass it as a G2 point?
There was a problem hiding this comment.
We definitely could, but i like having the PK as an octet string. It's more intuitive for a developer IMO. Also updating this would be a bigger change (will need to update the octets_to_pubkey to something like validate_pubkey which I'm not sure how it would look like. Opened #219 to keep track of this.
BasileiosKal
force-pushed
the
encoding_updates
branch
from
aee86e0 to
b6df3ca
Compare
…s-signature into BasileiosKal-encoding_updates
|
With the CFRG draft adoption the draft name has changed again, please rebase this PR to target the new draft name |
BasileiosKal
force-pushed
the
encoding_updates
branch
from
a542045 to
e84c3d9
Compare
This was referenced Oct 6, 2022
Closed
Closed
tplooker
approved these changes
Oct 11, 2022
andrewwhitehead
approved these changes
Oct 11, 2022
|
Multiple approvals, open over two weeks, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207
DSTs are defined as octet strings everywhere. Default DSTs are turned into octet strings using
utf8. Also, theciphersuite_idis excluded from the “must be prepended with its length” rule when hashing (no reason for it).