Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PK format and validation #266

Closed
wants to merge 2 commits into from
Closed

PK format and validation #266

wants to merge 2 commits into from

Conversation

BasileiosKal
Copy link
Contributor

Addressing point -A- from issue #246

@BasileiosKal BasileiosKal mentioned this pull request Jun 14, 2023
Merged
christianpaquin
christianpaquin approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@christianpaquin christianpaquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BasileiosKal
Copy link
Contributor Author

This PR is conflicting with #268, by introducing further inconsistency on the inputs (points vs octet strings), while 268 tries to define all core operation inputs as octets.

Converting to draft until #268 is resolved.

@BasileiosKal BasileiosKal marked this pull request as draft June 19, 2023 19:16
@BasileiosKal
Copy link
Contributor Author

Discussed on the WG call of the 7th of Aug. Will close as no longer applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianpaquin christianpaquin christianpaquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BasileiosKal @christianpaquin