generated from decentralized-identity/template-for-work-items
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example readme #15
Merged
Merged
+86
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vmc-crossmint
commented
Oct 10, 2024
•
edited
Loading
edited
- Add example readme
- Fix codeowners generation
- Add JSON schema example
…y/credential-schemas into vmc/example_entity
…y/credential-schemas into vmc/example_entity
vmc-crossmint
force-pushed
the
vmc/example_entity
branch
from
October 10, 2024 14:31
436fb68
to
2f5d009
Compare
vmc-crossmint
force-pushed
the
vmc/example_entity
branch
from
October 10, 2024 14:41
3b35000
to
01954fb
Compare
…y/credential-schemas into vmc/example_entity
…y/credential-schemas into vmc/example_entity
…y/credential-schemas into vmc/example_entity
vmc-crossmint
requested review from
kimdhamilton and
ottomorac
as code owners
October 10, 2024 14:48
…y/credential-schemas into vmc/example_entity
kimdhamilton
approved these changes
Oct 10, 2024
ottomorac
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small suggestions / corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.