Account for ImportError due to tensorflow version #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @danibene, we are indeed working on bugs that have been introduced with the use of TF 2.13. Thank you for the one you've raised. The tests are still failing due to a deserialization error of our custom objects. |
|
I've opened a new PR #76 to fix the different issues introduced with TensorFlow 2.13. I cherry-picked your commit to fix the |
Yup sounds good thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed that there was an ImportError in a test using tensorflow version 2.13.0: https://github.com/deel-ai/deel-lip/actions/runs/5545972296/job/15088178944
So I changed
except ModuleNotFoundError:toexcept ImportError or ModuleNotFoundError:in the relevant file where the import error was occurring.