Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: create custom type, protocol, etc.. that would fit better our classes #26

Open
lucashervier opened this issue Jun 24, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed refactor Improvements relative to existing code

Comments

@lucashervier
Copy link
Collaborator

No description provided.

@lucashervier lucashervier added enhancement New feature or request help wanted Extra attention is needed refactor Improvements relative to existing code labels Jun 24, 2021
@fel-thomas
Copy link
Member

That's exactly why I put type into it's own module. I have nevertheless a reluctance on the fact that the documentation can be less clear (what is a protocol for a user who does not know the lib)

@lucashervier
Copy link
Collaborator Author

It is a good point, but then we have to make sure the type we use are necessary AND sufficient. Because, it is nice that a user can understand the documentation but it is even better if it allows him to do what he wants!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed refactor Improvements relative to existing code
Projects
None yet
Development

No branches or pull requests

2 participants