Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error occurred while downloading the gif image #48

Open
wohaoeRiver opened this issue Mar 5, 2024 · 3 comments
Open

An error occurred while downloading the gif image #48

wohaoeRiver opened this issue Mar 5, 2024 · 3 comments

Comments

@wohaoeRiver
Copy link

wohaoeRiver commented Mar 5, 2024

image1
image2
6C1H8D35HFO_8FFSU
(The use of classfilteraction in Picture 3 is wrong,Don't learn from me.
right method →_→ https://deepghs.github.io/imgutils/main/api_doc/validate/classify.html

errors when encountering GIF images while downloading pictures through PixivSearchSource。 When downloading regular images there is no problem, but encountering GIFs causes errors。

@narugo1992
Copy link
Contributor

well, i think the solution should be just ignore errors from temporary directories' cleaning. just put a warning information is okay.

@wohaoeRiver
Copy link
Author

well, i think the solution should be just ignore errors from temporary directories' cleaning. just put a warning information is okay.我认为解决办法应该是忽略临时目录清理时的错误。只需提供一个警告信息即可。

Thank you. After setting ignore_cleanup_errors to True in the TemporaryDirectory called in the _make_gif_for_ugoira method in source/pixiv.py, the problem was resolved.
image

@narugo1992
Copy link
Contributor

well, i think the solution should be just ignore errors from temporary directories' cleaning. just put a warning information is okay.我认为解决办法应该是忽略临时目录清理时的错误。只需提供一个警告信息即可。

Thank you. After setting ignore_cleanup_errors to True in the TemporaryDirectory called in the _make_gif_for_ugoira method in source/pixiv.py, the problem was resolved. image

so maybe u can open a pull request? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants