Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate model entries #47

Open
FynnBe opened this issue Oct 5, 2022 · 3 comments
Open

Duplicate model entries #47

FynnBe opened this issue Oct 5, 2022 · 3 comments

Comments

@FynnBe
Copy link
Contributor

FynnBe commented Oct 5, 2022

Some models, e.g.
are linked to the bioimage.io collection via https://github.com/deepimagej/models/blob/master/manifest.bioimage.io.yaml
and a zenodo record.
As discussed previously we should prefer the zenodo records to host models and remove the entries in this manifest here.

@carlosuc3m
Copy link
Collaborator

carlosuc3m commented Oct 5, 2022

@lmoyasans @esgomezm we should delete the models from here when possible and upload them through the bioimage.io uploader.
The models where kep in the manifest.yaml as legacy from the previous DIJ installer which parsed that file to retrieve the models. Since deepimagej/deepimagej-plugin@fb0fa72 the models can be downloaded in the same way as the bioimage.io packager. So the manifest yaml is not needed to download models

@esgomezm
Copy link
Collaborator

esgomezm commented Oct 5, 2022

Hi there, this has been done already as soon as the models were correctly uploaded (there are many open pull requests) such as the cases of FRUNEt, ZCDL4M unets, pancreatic cells etc. which have already disappeared from the main manifest yaml of deepImageJ. Still when removing those models from the yaml, please, for our internal record, keep them updated here https://github.com/deepimagej/models/blob/master/manifest.bioimageio_dij_install_model.yaml.

@carlosuc3m
Copy link
Collaborator

I have created a list with the errors that I have seen in each of the models. A couple of the DIJ ones have errors coming from the zipped model, as it is not up to date with the model defined in the model card. If we keep the redundancy of the zipped model, it is important to make sure they are fine as it could be a source of errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants