Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The readability of type 'hpsi_info' maybe is poor #5768

Open
8 tasks
haozhihan opened this issue Dec 26, 2024 · 0 comments
Open
8 tasks

The readability of type 'hpsi_info' maybe is poor #5768

haozhihan opened this issue Dec 26, 2024 · 0 comments
Labels
Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Comments

@haozhihan
Copy link
Collaborator

Describe the Code Quality Issue

typedef std::tuple<const psi::Psi<T, Device>*, const psi::Range, T*> hpsi_info;

It is difficult for users to directly know what the data in this tuple is.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.
@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS
Projects
None yet
Development

No branches or pull requests

2 participants