Skip to content

Commit

Permalink
Extending MockViewBase with and methods. Silencing pandas linter erro…
Browse files Browse the repository at this point in the history
…r (TBD if this is going to be covered in this PR).
  • Loading branch information
patryk-wyzgowski committed Jul 12, 2024
1 parent 41c876e commit 44d9b6d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/dbally/views/pandas_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ async def apply_aggregation(self, aggregation: IQLQuery) -> None:
Args:
aggregation: IQLQuery object representing the aggregation to apply
"""
pass
pass # pylint: disable=unnecessary-pass

async def build_filter_node(self, node: syntax.Node) -> pd.Series:
"""
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/mocks.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ def list_filters(self) -> List[ExposedFunction]:
async def apply_filters(self, filters: IQLQuery) -> None:
...

def list_aggregations(self) -> List[ExposedFunction]:
return []

async def apply_aggregation(self, filters: IQLQuery) -> None:
...

def execute(self, dry_run=False) -> ViewExecutionResult:
return ViewExecutionResult(results=[], context={})

Expand Down

0 comments on commit 44d9b6d

Please sign in to comment.