Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add aggregation capabilities for pandas DataFrameBaseView #81

Closed
PatrykWyzgowski opened this issue Aug 12, 2024 · 1 comment · Fixed by #62
Closed

feat: Add aggregation capabilities for pandas DataFrameBaseView #81

PatrykWyzgowski opened this issue Aug 12, 2024 · 1 comment · Fixed by #62
Labels
feature New feature or request

Comments

@PatrykWyzgowski
Copy link
Contributor

PatrykWyzgowski commented Aug 12, 2024

Feature description

Implement aggregation mechanism for DataFrameBaseView. It is marked with TODO in pandas_base.py file in this PR:

async def apply_aggregation(self, aggregation: IQLQuery) -> None:
    """
    Applies the aggregation of choice to the view.

    Args:
        aggregation: IQLQuery object representing the aggregation to apply
    """
    # TODO - to be covered in a separate ticket.`

Motivation

Currently single aggregation is supported by SqlAlchemyBaseView, though its parent MethodsBaseView (also a parent for DataFrameBaseView) posseses and interface for this. To unify capabilities of the most high-level views implemented (for SQLAlchemy and Pandas respectively) one should implement aggregation mechanism for DataFrameBaseView as well.

Additional context

No response

@PatrykWyzgowski PatrykWyzgowski added the feature New feature or request label Aug 12, 2024
@micpst
Copy link
Collaborator

micpst commented Aug 20, 2024

This will be implemented in #62

@micpst micpst linked a pull request Aug 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants