Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llama-2-chat integration #9

Closed
wants to merge 30 commits into from
Closed

Llama-2-chat integration #9

wants to merge 30 commits into from

Conversation

eryk-dsai
Copy link

@eryk-dsai eryk-dsai commented Aug 31, 2023

No description provided.

@eryk-dsai eryk-dsai marked this pull request as ready for review September 1, 2023 13:26
Copy link

@piotr-grodek-dsai piotr-grodek-dsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments

libs/langchain/langchain/chat_models/huggingface_llama2.py Outdated Show resolved Hide resolved
libs/langchain/langchain/chat_models/huggingface_llama2.py Outdated Show resolved Hide resolved
libs/langchain/langchain/chat_models/huggingface_llama2.py Outdated Show resolved Hide resolved
libs/langchain/langchain/chat_models/huggingface_llama2.py Outdated Show resolved Hide resolved
libs/langchain/langchain/chat_models/huggingface_llama2.py Outdated Show resolved Hide resolved
docs/extras/integrations/chat/huggingface_llama2.ipynb Outdated Show resolved Hide resolved
docs/extras/integrations/chat/huggingface_llama2.ipynb Outdated Show resolved Hide resolved
docs/extras/integrations/chat/huggingface_llama2.ipynb Outdated Show resolved Hide resolved
@maks-operlejn-ds
Copy link

LGTM

@@ -2,8 +2,6 @@
from enum import Enum
from typing import Any, Dict, List, Optional, Union

from transformers.pipelines import TextGenerationPipeline

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have if type_checking - as it is done for other places.

eryk-dsai pushed a commit that referenced this pull request Oct 6, 2023
proper embeddings and rolling window average
@eryk-dsai eryk-dsai closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants