Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run mypy outside of pre-commit #124

Closed
ludwiktrammer opened this issue Oct 22, 2024 · 0 comments · Fixed by #87
Closed

chore: run mypy outside of pre-commit #124

ludwiktrammer opened this issue Oct 22, 2024 · 0 comments · Fixed by #87
Assignees
Labels
chore Changes to the build process or repo setup
Milestone

Comments

@ludwiktrammer
Copy link
Collaborator

Currently in CI we only run mypy in the environment created by pre-commit, which lacks our dependencies, which means that all checks related to checking the correctness of typing when running code from dependencies (e.g., executing a method from a class defined in a library) are skipped. Because of this, we already accumulated quite a lot of problems like this in out codebase.

We should configure CI to run standalone mypy.

@ludwiktrammer ludwiktrammer moved this to Backlog in ragbits Oct 22, 2024
@ludwiktrammer ludwiktrammer self-assigned this Oct 22, 2024
@ludwiktrammer ludwiktrammer added the chore Changes to the build process or repo setup label Oct 22, 2024
@ludwiktrammer ludwiktrammer moved this from Backlog to Ready in ragbits Oct 22, 2024
@ludwiktrammer ludwiktrammer removed their assignment Oct 22, 2024
@mhordynski mhordynski added this to the Ragbits 0.3 milestone Oct 23, 2024
@akonarski-ds akonarski-ds self-assigned this Oct 24, 2024
@akonarski-ds akonarski-ds linked a pull request Oct 24, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Ready to Done in ragbits Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes to the build process or repo setup
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants