Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(llms): default values for default_llm_factories #154

Closed
ludwiktrammer opened this issue Oct 28, 2024 · 0 comments · Fixed by #209
Closed

feat(llms): default values for default_llm_factories #154

ludwiktrammer opened this issue Oct 28, 2024 · 0 comments · Fixed by #209
Assignees
@kdziedzic68
Labels
feature New feature or request
Milestone
Ragbits 0.5

Comments

@ludwiktrammer
Copy link
Collaborator

ludwiktrammer commented Oct 28, 2024 •
edited
Loading

Currently values default values (i.e., values used when the user don't specify the option in their pyproject.toml) of each key in default_llm_factories is None. This means that our code can't assume that some default LLM will alway be provided, and have to either fallback to some other hardcoded LLM or fail.

Maybe we should provide some sensible defaults for those options.
@ludwiktrammer ludwiktrammer converted this from a draft issue Oct 28, 2024
@ludwiktrammer ludwiktrammer self-assigned this Oct 28, 2024
@ludwiktrammer ludwiktrammer moved this from Backlog to Ready in ragbits Oct 30, 2024
@ludwiktrammer ludwiktrammer removed their assignment Oct 30, 2024
@mhordynski mhordynski added this to the Ragbits 0.5 milestone Nov 4, 2024
@kdziedzic68 kdziedzic68 self-assigned this Nov 26, 2024
@micpst micpst linked a pull request Nov 28, 2024 that will close this issue
feat(llms): default values for default_llm_factories #209
Merged
@micpst micpst added the feature New feature or request label Nov 28, 2024
@mhordynski mhordynski moved this from In Progress to In review in ragbits Nov 28, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ragbits Nov 28, 2024
@ludwiktrammer ludwiktrammer mentioned this issue Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdziedzic68 kdziedzic68

Labels
feature New feature or request
Projects
ragbits
Status: Done
Milestone
Ragbits 0.5
Development

Successfully merging a pull request may close this issue.

feat(llms): default values for default_llm_factories deepsense-ai/ragbits
4 participants
@ludwiktrammer @mhordynski @micpst @kdziedzic68