Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document-search): do not create all of provider instances when importing document processor #158

Closed
konrad-czarnota-ds opened this issue Oct 30, 2024 · 0 comments · Fixed by #219
Closed

fix(document-search): do not create all of provider instances when importing document processor #158

konrad-czarnota-ds opened this issue Oct 30, 2024 · 0 comments · Fixed by #219
Assignees
@kdziedzic68
Labels
bug Something isn't working document search Changes to the document search package
Milestone
Ragbits 0.5

Comments

@konrad-czarnota-ds
Copy link
Collaborator

konrad-czarnota-ds commented Oct 30, 2024 •
edited
Loading

When importing DocumentProcessor there is a list of default providers that are created here. I think it should be done in a lazy way, we only create the ones that are needed to be used.
@konrad-czarnota-ds konrad-czarnota-ds converted this from a draft issue Oct 30, 2024
@konrad-czarnota-ds konrad-czarnota-ds added the document search Changes to the document search package label Oct 30, 2024
@konrad-czarnota-ds konrad-czarnota-ds self-assigned this Oct 30, 2024
@konrad-czarnota-ds konrad-czarnota-ds added the bug Something isn't working label Oct 30, 2024
@konrad-czarnota-ds konrad-czarnota-ds moved this from Backlog to Ready in ragbits Oct 30, 2024
@konrad-czarnota-ds konrad-czarnota-ds removed their assignment Oct 30, 2024
@mhordynski mhordynski added this to the Ragbits 0.5 milestone Nov 4, 2024
@kdziedzic68 kdziedzic68 moved this from Ready to In Progress in ragbits Nov 29, 2024
@kdziedzic68 kdziedzic68 linked a pull request Dec 2, 2024 that will close this issue
fix(document-search): do not create all of provider instances when importing document processor #219
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in ragbits Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdziedzic68 kdziedzic68

Labels
bug Something isn't working document search Changes to the document search package
Projects
ragbits
Status: Done
Milestone
Ragbits 0.5
3 participants
@mhordynski @konrad-czarnota-ds @kdziedzic68