Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Install LiteLLM by default #231

Closed
ludwiktrammer opened this issue Dec 4, 2024 · 1 comment · Fixed by #236
Closed

feat: Install LiteLLM by default #231

ludwiktrammer opened this issue Dec 4, 2024 · 1 comment · Fixed by #236
Assignees
Milestone

Comments

@ludwiktrammer
Copy link
Collaborator

ludwiktrammer commented Dec 4, 2024

Currently ragbits and ragbits-core are installed without installing LiteLLM (which requires explicitely installing ragbits[litellm].

Motivation

  1. Ragbits requires LiteLLM to do almost anything useful (besides more advanced use cases of running local LLMs)
  2. After feat(llms): default values for default_llm_factories #154, Ragbits comes pre configured with default LLM values which use LiteLLM. This currently leads to Ragbits not being able to use its own defaults by default ;)

Steps

  • ragbits-core should list LiteLLM as its direct dependency.
  • Conditional imports of litellm should be changes to regular imports
  • Make LiteLLM available from the root ragbits.core.llms module
  • Test that LiteLLM can imported without full path by LLM.subclass_from_config by adding test similar to tests.unit.embeddings.test_from_config.test_subclass_from_config_default_path to tests.unit.llms.test_from_config
  • All places that mention ragbits[litellm] in the documentation (e.g., Quickstart 1) should be adjusted accordingly
@ludwiktrammer ludwiktrammer converted this from a draft issue Dec 4, 2024
@ludwiktrammer ludwiktrammer self-assigned this Dec 4, 2024
@mhordynski
Copy link
Member

mhordynski commented Dec 4, 2024

I totally agree! I'll go ahead and add it to 0.5.0 Milestone. It looks like a great improvement for a small effort.

@mhordynski mhordynski moved this from Backlog to Ready in ragbits Dec 4, 2024
@mhordynski mhordynski added this to the Ragbits 0.5 milestone Dec 4, 2024
@ludwiktrammer ludwiktrammer removed their assignment Dec 5, 2024
@mhordynski mhordynski moved this from Ready to In Progress in ragbits Dec 5, 2024
@mhordynski mhordynski self-assigned this Dec 5, 2024
@mhordynski mhordynski linked a pull request Dec 5, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in ragbits Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants