Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: merge llm client with llm #250

Closed
micpst opened this issue Dec 17, 2024 · 0 comments · Fixed by #270
Closed

refactor: merge llm client with llm #250

micpst opened this issue Dec 17, 2024 · 0 comments · Fixed by #270
Assignees
@nczerep
Labels
core Changes to the core package refactor Code change that neither fixes a bug nor adds a feature
Milestone
Ragbits 0.7

Comments

@micpst
Copy link
Collaborator

micpst commented Dec 17, 2024

The LLM class now acts as a proxy for LLMClient and does not provide much functionality on its own. We should move the LLMClient logic to the LLM class and completely remove the client abstraction. This should simplify the interface and reduce ambiguity.
@micpst micpst added refactor Code change that neither fixes a bug nor adds a feature core Changes to the core package labels Dec 17, 2024
@micpst micpst self-assigned this Dec 17, 2024
@micpst micpst added this to ragbits Dec 17, 2024
@micpst micpst moved this to Backlog in ragbits Dec 17, 2024
@ludwiktrammer ludwiktrammer moved this from Backlog to Ready in ragbits Jan 2, 2025
@ludwiktrammer ludwiktrammer added this to the Ragbits 0.7 milestone Jan 2, 2025
@ludwiktrammer ludwiktrammer moved this from Ready to In Progress in ragbits Jan 9, 2025
@micpst micpst linked a pull request Jan 10, 2025 that will close this issue
refactor: merge llm client with llm #270
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in ragbits Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nczerep nczerep

Labels
core Changes to the core package refactor Code change that neither fixes a bug nor adds a feature
Projects
ragbits
Status: Done
Milestone
Ragbits 0.7
Development

Successfully merging a pull request may close this issue.

refactor: merge llm client with llm deepsense-ai/ragbits
3 participants
@ludwiktrammer @micpst @nczerep