Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: end-to-end support for images #85

Closed
2 tasks
ludwiktrammer opened this issue Oct 10, 2024 · 0 comments · Fixed by #172
Closed
2 tasks

feat: end-to-end support for images #85

ludwiktrammer opened this issue Oct 10, 2024 · 0 comments · Fixed by #172
Assignees
@ludwiktrammer
Labels
feature New feature or request
Milestone
Ragbits 0.4

Comments

@ludwiktrammer
Copy link
Collaborator

ludwiktrammer commented Oct 10, 2024 •
edited
Loading

Ragbits should support images as first class citizens, in addition to text. In particular:

  • Embedders should be able to optionaly embed images (probably they should implement a special ImageEmbedder interface to indicated this)
  • When configured with an Embedder that supports images, the DocumentSearch should use the embedders image embedding capabilities to generate the embeddings (i.e., call embed_image instead of embed_text method on the embedder)

See also #100
@ludwiktrammer ludwiktrammer moved this to Backlog in ragbits Oct 10, 2024
@ludwiktrammer ludwiktrammer mentioned this issue Oct 10, 2024
Closed
@micpst micpst added feature New feature or request document search Changes to the document search package core Changes to the core package and removed document search Changes to the document search package core Changes to the core package labels Oct 11, 2024
@ludwiktrammer ludwiktrammer self-assigned this Oct 14, 2024
@ludwiktrammer ludwiktrammer moved this from Backlog to Ready in ragbits Oct 22, 2024
@ludwiktrammer ludwiktrammer removed their assignment Oct 22, 2024
@mhordynski mhordynski added this to the Ragbits 0.4 milestone Oct 23, 2024
@ludwiktrammer ludwiktrammer self-assigned this Oct 29, 2024
@ludwiktrammer ludwiktrammer linked a pull request Nov 5, 2024 that will close this issue
feat(document-search): Support for ingesting images #172
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in ragbits Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludwiktrammer ludwiktrammer

Labels
feature New feature or request
Projects
ragbits
Status: Done
Milestone
Ragbits 0.4
Development

Successfully merging a pull request may close this issue.

feat(document-search): Support for ingesting images deepsense-ai/ragbits
3 participants
@ludwiktrammer @mhordynski @micpst